Simon Schenk
Simon Schenk
Yes, this looks good. Would you mind adding a test and un-drafting?
> @runtologist @easel what's the state of this pull request? I do not have a strong opinion, it can be merged I guess.
There aren't two spans per trace. The root span lives for the entire lifespan of the application, not per request. We chose this approach for the reason you just described....
Then we should take a look at the example apps. Maybe they have a bug. I can take a look next week.
The way the examples are written, a fresh layer is provided per request. Every fresh layer creates a fresh root span. Passing around the ZLayer in the examples is the...
We considered making the span optional, but that does not feel right for me. Without a span most methods would need to fail of silently do a noop. That makes...
Not tested, bu shouldn't this work? ```scala def processorToZPipeline[In, Out](processor: Processor[In, Out]): ZPipeline[Scope, Throwable, In, Out] = ZPipeline.unwrap( for { signalErrorSink >> sourcePipe ) ```
Well, it doesn't.
This is awesome. Thanks for this contribution! Just one small question.
@swachter OK. Let me know if you'd like me to take a look.