Trung Lê

Results 125 comments of Trung Lê
trafficstars

can you please give a short description of what this commit introduces?

@IlyaSmirnov91 I think we could close this PR now

I do not think it is relevant anymore. At least we should rebase p10 with current master branch

@nnande could you please rebase with main branch?

@kellertk yours does not work simply because you only unset the environment variables and NOT modify the `GITHUB_ENV` file so the next step would reload the environment variables from that...

The `sed -i "/badvar=/d" $GITHUB_ENV` suggestion from @AlexAtkinson won't work too because GitHub has disallowed any operation to do with that file. Yes, even if you `cp $GITHUB_ENV /tmp/my_temp`, GitHub...

@bkaradzic the `-B` would cover the scenario in which `ld` is located in non-standard location. However I do not think it is the flag to choose totally different linker, for...

@dandavison I'm fixing it atm

I could not even get the app compiled. I got lots of errors like this on Fedora 37: ``` /home/tle/Work/box86/src/wrapped/wrappedsdl2.c:693:5: note: in expansion of macro ‘PREPARE_VALIST’ 693 | PREPARE_VALIST; |...

@TheCodex6824 that's exactly what I am trying to figure out. If I could find the answer, I will let you know