Rui He

Results 46 comments of Rui He

I find that it is not relevant to os-prober and setting `GRUB_DISABLE_OS_PROBER=true` will not work. It is caused by line 142 of `/usr/sbin/grub2-mkconfig`: ```shell # Device containing our userland. Typically...

> systemd offers a whole lot of isolation knobs but the most reliable and complete in my opinion starts with DynamicUser=yes which will also reliably fix access to user home...

> I would say we should aim to switch to having the /sysroot directory be mode 0700 to start. You can of course just make this change in any systems...

@codebytere Seems this is not very compatible with #41769. How can we handle drop shadow when WCO is enabled?

Update: I've added support `thickFrame` to control whether to show window shadow on Wayland.

@codebytere I've added an implementation of GTK native WCO in 6ece5db. Would you plz have a look at it? IMO it looks more integrated with system look & feel. Screenshot...

BTW I found `hasShadow` has no effect on both X11 and Wayland. On main branch, X11 will always show shadow and Wayland will not despite the setting of `hasShadow`. I'm...

> We have another PR that is about to land (https://github.com/electron/electron/pull/41769) - if you wouldn't mind rebasing after that PR lands, that would be great! @VerteDinde As I've pointed out...

> Could I ask you to rebase this PR against main so we can get the tests running green again? I've done rebasing. The build fails for Windows. I'll fix...

@codebytere @deepak1556 > its being Wayland-only thus far Well, `ClientFrameView` can work on X11, though it is not the default. > accomplish the intended goal of prod use of WCO...