Rui

Results 14 comments of Rui

Thanks for the kind and thoughtful reply, @Gelio. I took a stab at it on #30.

Hey, thanks for the thorough review! As for the changes of this PR, I believe that ensuring that the ancestor's parent node is not a hook or a component clears...

> In the snippet you shared, useRef is called within React.memo, which is a valid context for a hook call. That is correct. I was attempting to exercise corner cases...

> Hey! You can definitely move the UI out of the `TldrawEditor ` component. To make that work just use the `onMount` prop, which should give you the editor once...

Hey @jabolina, first and foremost much thanks and props for taking the time to do this! Really really appreciate the effort and kindness 😊 Observability is definitely a valuable and...

@Juice10 @YunFeng0817 Question: why do this as a CI step that only fixes it for `web-extension`, instead of fixing this for all packages published by this repo that ends up...

Running into this as well. Our current workaround has been to patch `patch-package` so it doesn't use `yarn`.. though it would be desirable to not have to do this.

Question: why do this as a post-step job in CI, if this could be solved simply by bumping `vite` to `^6.0.1`? https://github.com/rrweb-io/rrweb/issues/1578#issuecomment-2612855699

Apologies for the delay, somehow I missed the notifications from this PR. @Juice10 Thanks for creating the changeset. I've just rebased from `master`, and I'll check back until CI is...