Nicolas Ruflin
Nicolas Ruflin
The diff is currently a bit larger as I had to update some dependencies to still work with 7.x
The documentation on https://elastica.io/ is not too detailed, but I recommend to take a look at the test suite which has lots of examples: https://github.com/ruflin/Elastica/tree/9.x/tests There are 2 ways how...
I leave it to @adriansr to comment :-)
@ryu818 Really sorry for the late reply. I just started CI on it. Any chance you could add a line to the changelog?
Ideally we would have some tests that test the changes. I will try to have a look if the test failures are related to this change or not. My guess...
BTW this is the failure I'm worried about: ``` 1) Elastica\Test\IndexTest::testAddDocumentAcrossIndices Elastic\Elasticsearch\Exception\ClientResponseException: 400 Bad Request: {"error":{"root_cause":[{"type":"action_request_validation_exception","reason":"Validation Failed: 1: ifSeqNo is unassigned, but primary term is [1];"}],"type":"action_request_validation_exception","reason":"Validation Failed: 1: ifSeqNo is...
The proposed change sounds sensible to me. Do you want to try to implement it that way and add a test? For the changelog: It seems your editor "adjusted" some...
Hi @ryu818 Sorry for the late reply. At the moment I don't get to look at it in much detail but it is on my list to have a look...
Have a PR with a potential fix here: https://github.com/ruflin/Elastica/pull/2243
@ryu818 Can you rebase this either on 8.x or 9.x to continue? Tests should be green now.