Nicolas Ruflin

Results 332 comments of Nicolas Ruflin

`data_stream.dataset` should only be set as `constant_keyword` when the [data stream naming scheme](https://www.elastic.co/blog/an-introduction-to-the-elastic-data-stream-naming-scheme) is used. In the scenario of filebeat-* data streams, `data_stream.*` fields must be set as `keyword` to...

The fields in Beats are set here: https://github.com/elastic/beats/blob/main/libbeat/_meta/fields.ecs.yml#L894 As filebeat always ships to a single data stream, this must be changed to `keyword` instead of `constant_keyword`. > we should answer...

> I'm not entirely convinced this is a true statement. What if the custom log integration was used? The data_stream.dataset would be constant keyword, but the value would be set...

Here is an interesting new feature in Elasticsearch that could help with the dots: https://github.com/elastic/elasticsearch/pull/86166

Here is the change from 7.3.1 to 7.3.2: https://github.com/ruflin/Elastica/compare/7.3.1...7.3.2 My assumption is the problem comes from this change here: https://github.com/ruflin/Elastica/pull/2184 @csabavirag I assume you are using `addDocument` or `addScript`? We...

@reedy Do you have an option to quickly check if an additional check if `$this->_client` is set would fix it. Basically use a modified Elastica version and run the test...

I did ask AI to do a quick pull request in case this helps with testing? https://github.com/ruflin/Elastica/pull/2269 @reedy Did you run the tests on your end to see if it...

I just looked again at the PR. What I realised is that `null` check is the second condition instead of the first one. Let me push another commit and invert...

I pushed another commit to https://github.com/ruflin/Elastica/pull/2269 A bit late on my end, but could you check again?

I'll have a look again. Lets get this fixed once and for all.