Alexey Kinev
Alexey Kinev
Hi Charles! I agree with your considerations, I'll rewrite the code with more explicit 3-tuple logic and I think it would be right to add tests for registering actions urls.
Hi Charles! I've updated actions definitions to point directly to methods, but I still use 2-tuple. All tests pass. Looks ok?
Well, I believe most cases are covered by existing tests, because delete and export actions are defined in the new generic way. Custom actions have no difference with export and...
For Sentry integration I came up to such code: ```python import sys from loguru import logger import logging from sentry_sdk.integrations.logging import LoggingIntegration, EventHandler SENTRY_DSN = '...' logger.remove() sentry_sdk.init( SENTRY_DSN, integrations=[LoggingIntegration(level=None,...
@Delgan unfortunately, I faced weird issue, I got endless messages sent to the Sentry server: ``` ... 2020-10-08 21:34:56.524 | DEBUG | sentry_sdk.integrations.logging:sentry_patched_callhandlers:83 - https://sentry.mysite.org:443 "POST /api/9/store/ HTTP/1.1" 200 41...
> Would this be possible that events emitted by the EventHandler() would somehow be captured by Sentry which would generate new logs causing EventHandler() to emit new events and so...
@Delgan Yes, it's possible that some other hooks are also involved, I'll try to provide basic reproducible example.
Pipeline object is not thread-safe as claimed for redis-py: https://github.com/andymccurdy/redis-py#thread-safety Probably we're having similar limitation here.
@ganeshrvel Thanks for the awesome development! I'd personally vote for leaving GUI part as-is on Electron, it's basically fine. And adding the filesystem / Finder integration level, it would feel...
@grazor does the same error happen with sync queries? UPD Oh, I see, with sync queries it's OK. Probably some issue with `aiomysql` or with connection initialization.