Ruben de Laat

Tolerance documentation 1.0.0

6

With https://github.com/buildingSMART/IDS/pull/294 closed and IDS version now at 1.0.0, can we assume the documentation to be final? https://github.com/buildingSMART/IDS/blob/development/Documentation/developer-guide.md#precision With this implemented I am getting quite a lot of failed test...

Test case naming consistency

2

Many of the new IDS test cases (mostly the ones in the tolerance folder) do not conform to the earlier used naming convention of using either the "pass-" or "fail-"...

2 testcases have .html file instead of .ifc

2

The following two test cases have a .html file instead of a .ifc file. `property\pass-floating_point_numbers_are_compared_with_a_1e_6_tolerance_1_4` `property\pass-floating_point_numbers_are_compared_with_a_1e_6_tolerance_2_4`

Tolerance in 1.0

5

When implementing the tolerance check as described in https://github.com/buildingSMART/IDS/blob/development/Documentation/ImplementersDocumentation/tolerance.md a lot of the tolerance test cases fail (12). When modifying the logic a little bit (changing the > and <...

pass-an_optional_classification_value_passes_if_null

1

I think this test case is meant to be checking whether an attached classification without an actual value passes an optional classification requirement. However the checked object (IfcWall) does not...