IDS icon indicating copy to clipboard operation
IDS copied to clipboard

Tolerance documentation 1.0.0

Open rubendel opened this issue 1 year ago • 6 comments

With https://github.com/buildingSMART/IDS/pull/294 closed and IDS version now at 1.0.0, can we assume the documentation to be final? https://github.com/buildingSMART/IDS/blob/development/Documentation/developer-guide.md#precision

With this implemented I am getting quite a lot of failed test cases

rubendel avatar Jun 04 '24 13:06 rubendel

I think #294 wasn't supposed to be closed. The bit of documentation you referenced misses the abs() part, so doesn't properly handle negative values. See https://github.com/buildingSMART/IDS/blob/0d50fd8f2dbd5b388f6fafb67da255cc3ce2b4ca/Documentation/tolerance.md

aothms avatar Jun 04 '24 13:06 aothms

Hello Ruben, not quite yet, the vote held by the panel ratified the schema. We are still working with the IDS development group to complete the test case documentation. My personal view is that this will eventually result in a robust implementation across all platform, and I hope that a certification process will guarantee such coherence for all implementers. I'm hoping to complete this step before the end of the month. I welcome all feedback on test-cases and I'm available for any conversation or one-to-one that might help implementers. Best, Claudio

CBenghi avatar Jun 04 '24 13:06 CBenghi

The issue closed automatically when merging the pull request. Had to process all PRs due to the change in default branche. Let's indeed take some time to properly document this (and update Audit tool as well)

berlotti avatar Jun 04 '24 14:06 berlotti

@aothms Ah thanks Thomas, I did see a reference to the mentioned document, but it does not exist in the development branch. Nice work, don't understand much of math symbols, but adding abs I can :). @CBenghi Ok that's clear, I'll report whatever I find.

rubendel avatar Jun 04 '24 20:06 rubendel

@rubendel sorry, by mistake, I closed this PR while synchronizing the IDS repository... @CBenghi, could you directly add the file on the development branch?

giuseppeverduciALMA avatar Jun 05 '24 07:06 giuseppeverduciALMA

The tolerance.md file is now added to the development (#317).

atomczak avatar Jun 10 '24 10:06 atomczak

please confirm if this can be closed now @rubendel @CBenghi

atomczak avatar Aug 21 '24 19:08 atomczak