Ruairidh South comments

Repositories
Issues
Comments

Results 4 comments of


                                            Ruairidh South

StatsBase.sample should warn about weights containing Inf/NaN

I recently ran into a bug due to this issue. A warning about Inf weights would have helped me to find the problem faster. I see the PR wasn't accepted...

StatsBase.sample should warn about weights containing Inf/NaN

> Actually the PR wasn't rejected, it was closed by its author (I don't know why). Would you be willing to make a new PR with its contents? #814

Throw DomainError when sampling with NaN/Inf weights

> Fair enough. Nobody complained on Slack so maybe this corner case isn't used in practice. > > @ruairidhs Sorry for the change in plans, but would you be willing...

Throw DomainError when sampling with NaN/Inf weights

I added a check when constructing AbstractWeights and also for setindex!. Let me know what you think, happy to make changes