Ryan Turnquist
Ryan Turnquist
I've been thinking about this and I believe we can do something here. I'll lay out my thoughts and see if they make sense. ### Expectations _The middleware feature should:_...
Today we just rely on what the [browser provides for scroll restoration](https://developer.mozilla.org/en-US/docs/Web/API/History/scrollRestoration) which does work with both the default path/history integration and hash integration; however it seems limited to work...
Hmm, `composedPath` is a [widely supported](https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath#browser_compatibility) property of the `Event` interface so this feels like Sentry is interfering. They replace `addEventListener` on the various event target prototypes with their own....
I think the issue is the Babel configuration. From Babel v7, `.babelrc` files are treated as[ relative configuration](https://babeljs.io/docs/en/config-files#file-relative-configuration) which from my understanding wont be applied to external packages. Changing the...
I tried using [this test](https://github.com/faassen/solid-minimal-jest/blob/64d6cddcbb0196c2f1b3fc0a66d43acad5226139/src/router.test.tsx#L73) from your example and noticed you didn't wrap you application in a Router component. After adding that and updating the test to use `fireEvent` from...
Ah, I was looking at [this version](https://github.com/faassen/solid-minimal-jest/blob/623f0c29ae2d4acbc1ce588d4fe8bdd05ac185a5/src/router.test.tsx) from the initial commit and just added the link click, promise await and an assertion on `location.pathname`. Let me pull your latest.
With the latest version that test will work, you just need to await the `user.click(link)`. In fact you don't even need the `Promise.resolve()` after it since all microtasks (updating the...
I pulled your latest and did a fresh install and now it does indeed fail on the reference error. Without the `await` I suspect the error is swallowed. Even though...
My apologies for not following up. 0.3.4 fixes the SVGAElement reference error issue so testing should work now. I would love a PR that adds component and/or integration tests even...
Yeah, that is fair. I need to add some more documentation on the subject and examples of well, everything. The router component accepts a couple different forms for `integration` including...