Romain

Results 345 comments of Romain

@smerschjohann I agree that overlap detection cannot be implemented for HostRegex matchers in the same way as for Host matchers. And that runtime checking of all regular expression patterns is...

Hello @clement-brodu, Thank you for your contribution. We've set the status to "design-review" to allow us to check the PR and ensure there is no deep impact on Traefik before...

Hello @yelvert, Thanks for this contribution! At first glance, tests are missing. Can you please add some tests?

@yelvert It looks good! I'm noticing that #8753 was about defining the url with all label providers, can you please address it also for the other label providers (ECS, Nomad,...

@yelvert The `url` field in the `Server` struct is omitted when deserializing labels, you should enable it via the struct tags.

> @rtribotte anything else needed for this? Sure, as mentioned earlier, https://github.com/traefik/traefik/issues/8753 was about defining the url with all label providers, can you please address it also for the other...

@yelvert Thanks for the addressing the other providers! > It looks like the Docker provider handles DockerSwarm, for this at least, if thats not the case, I didn't see where...

@yelvert Sure, the next version (v3.4.0) will have this feature.

Hello! @seepine There is no particular progress yet, but we agree this would be nice good enhancement. If you or another community member would like to build it before that...

Hello @tareksalem, Thanks for reporting this! I'm marking this issue as a proposal to be a place to discuss what should be done to be more consistent. After a quick...