Romain

Results 345 comments of Romain

@tonybart1337 Thanks! I think panics should be reserved for cases where the state is unexpected or irrecoverable, and here it seems possible to properly handle the response or close the...

Hello @tonybart1337, Actually, I think you are right about reflecting the panic, this let the net/http server handle the response abortion. I have opened https://github.com/tonybart1337/traefik/pull/1 for review. Could please address...

Thanks @tonybart1337 for merging the PR, we will leave the waiting for fixes label until the unit tests are fixed and a new one is introduced for this new behavior.

Hey @hanxiantao, Thanks for your suggestion. We are interested in this issue but are unsure about the use case and the traction it will receive, so we are going to...

Hi @charlie0129, Sorry for the late reply. We have discussed this issue and decided to bring this behavior (strictly following the Ingress spec) in a non-breaking way for the current...

Hi @charlie0129, Thanks for addressing this. It seems good to me, let's see what are the thoughts of other maintainers when they will review this PR!

Hi @crltc, Thanks for reporting this! Can you please share a reproducible case? If any community members can investigate this and determine if there is a bug, we would really...

Hi @Alex-Waring, At first glance, we think it was a mistake to name the root span "Entrypoint", as it does not follow the semantic conventions. For this reason, we think...

Hi @Alex-Waring, > I've tried to go in that direction, however traefik has no support for transforming a URI into a url.template and that seems like a much larger piece...

Hi @Alex-Waring, Sure, but according to our previous discussion, I'm not sure about the status of the changes. Are you planning on making further iterations? Would you like us to...