Vitaly Rtishchev comments

Results 366 comments of


                                            Vitaly Rtishchev

Menu Component causing page to scroll

No, disabling transition on Menu component is not a good solution – we still want animations. Some bugs are not reproducible in storybook, it may be a strict mode development...

Menu Component causing page to scroll

Maybe

Menu Component causing page to scroll

Fixed in 5.2.7 – https://codesandbox.io/s/headless-glade-kw78v7?file=/src/App.js

[@mantine/core] Replace fromEntries with native function in createStyles function

Thanks!

Modal doesn't trap focus

Thanks for reporting!

Modal doesn't trap focus

Fixed in 5.1.4, Modal and Drawer components now support `withFocusReturn` prop, set it to false to prevent the component from returning focus to previous active element after Modal/Drawer is closed.

Modal doesn't trap focus

I'll make it dynamic without function in next patch

resetNavigationProgress is not working in dev mode with react 18 & strict mode

Does it work fine in production?

resetNavigationProgress is not working in dev mode with react 18 & strict mode

Okay, great, I'll be trying to fix the issue with event based function in next patch, hope that you will be able to validate the fix

resetNavigationProgress is not working in dev mode with react 18 & strict mode

Fixed in 5.1.3 @matinrco can you please verify that the fix works for you?