Vitaly Rtishchev comments

Results 366 comments of


                                            Vitaly Rtishchev

[@mantine/core] Group: extend props with BoxProps

Group is not supposed to be used as polymorphic component – it manages layout, not functionality, you should wrap it with `header` element instead: ```tsx ```

Encountered two children with the same key warning - Select with creatable prop

`shouldCreate` function determines whether creatable option should be displayed in the list, in the provided sandbox it always returns true, and thus creatable option is always rendered.

Encountered two children with the same key warning - Select with creatable prop

Fixed in 5.1.5

Fullscreen modal get cutted on the left

Fixed in 5.1.6

[@mantine/core] Timeline: Allow manually overriding of active state

Hi @Zegnat, sorry for long response, can you please resolve the conflicts?

NumberInput handles non-numeric values differently on initial render

Empty string maybe fine and can help with form resetting, but I do not think that `null` should be supported

NumberInput handles non-numeric values differently on initial render

I've decided that we should only support number and undefined in NumberInput, these cases work as expected – https://codesandbox.io/s/cool-cherry-0415m1?file=/src/App.tsx

Button text moves down more than button itself on clicked state

Button has translateY(1px) in active state, that is expected, if you do not want that behavior you can disable it with sx prop or using create styles

Button text moves down more than button itself on clicked state

Could not see anything of videos, they are too small, I've tested it on FIrefox on mac and it works fine

Button text moves down more than button itself on clicked state

Okay, I'll have a look