Richard Tibbles

Results 498 comments of Richard Tibbles

As this is new string here, I think this is to be expected!

Merging with failing check that is fixed on release-v0.17.x

Looks like all code changes are approved - so @pcenov and @radinamatic take it away!

My guess here is that the csrf_exempt decorator and the csrf_protect decorator are not quite working properly together: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/auth/api.py#L807 To fix this, I would suggest we tweak the inheritance slightly...

@pcenov were you testing with the asset from this PR for both sides of the learner creation? I tested with the asset from this PR for both the LOD that...

This looks good to go now - but I think we merged a couple of PRs that have conflicted with this! A quick rebase should sort it out.

You have now posted on 14 separate issues that are either already assigned or otherwise not marked with the `help-wanted` label. Please don't waste our limited time and resources by...

Hi @adibmbrk - yes, I think you're correct that it would need broader changes to the public channel APIs. As such, I suspect this is not appropriate for community contribution...

This is looking good in general - and I think most of the previous request for changes have been addressed, I just noticed one more thing around error handling.