kolibri
kolibri copied to clipboard
Distributed error reporting: Capture more information about the error and its environment
Summary
- Changes the model ErrorReports by renaming some fields like
error_fromtocategoryand more. - Adds new JSON fields for backend and frontend so we can store more contexts of error into them
- Update the remaining part of the code with the model changes, by update in backend error handling and frontend error handling mechanism
References
Closes #12376
Reviewer guidance
Cannot find a way yo get the node version in frontend
Testing checklist
- [x] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical user journeys are covered by Gherkin stories
- [x] Critical and brittle code paths are covered by unit tests
PR process
- [x] PR has the correct target branch and milestone
- [ ] PR has 'needs review' or 'work-in-progress' label
- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
- [ ] If this includes an internal dependency change, a link to the diff is provided
Reviewer checklist
- Automated test coverage is satisfactory
- PR is fully functional
- PR has been tested for accessibility regressions
- External dependency files were updated if necessary (
yarnandpip) - Documentation is updated
- Contributor is in AUTHORS.md
Build Artifacts
| Asset type | Download link |
|---|---|
| PEX file | kolibri-.pex |
| Windows Installer (EXE) | kolibri-0.16.2b2.dev0+git.1214.gbcac96a1-windows-setup-unsigned.exe |
| Debian Package | kolibri_0.16.2b2.dev0+git.1214.gbcac96a1-0ubuntu1_all.deb |
| Mac Installer (DMG) | kolibri-0.16.2b2.dev0+git.1214.gbcac96a1-0.4.2.dmg |
| Android Package (APK) | kolibri-0.16.2b2.dev0+git.1214.gbcac96a1-0.1.3-debug.apk |
| TAR file | kolibri-0.16.2b2.dev0+git.1214.gbcac96a1.tar.gz |
| WHL file | kolibri-0.16.2b2.dev0+git.1214.gbcac96a1-py2.py3-none-any.whl |
This is looking good in general - and I think most of the previous request for changes have been addressed, I just noticed one more thing around error handling.
Updated the PR