Rudi Theunissen

Results 191 comments of Rudi Theunissen

Coming back to this 2 years later, do we think that a third party sort is still the way to go?

@morrisonlevi the sort_r lib you linked falls back to their own quicksort implementation, but uses qsort_r if it is available. Seems reasonable to me to just include that header then....

Could you use `-timestamp` for the priority?

> It feels like a dirty workaround rather than proper solution though. I agree. 2.0 will have a Heap with an optional comparator that would work here.

Like a binary search tree? There is one on the way. :+1:

I believe this is because Ds\Map doesn't use the object's properties table to store the data. I don't see a way to support this, sorry. Could just fetch as array...

I'm not sure if array access would solve this. What you could do is create a class like `ResultMap` that creates an instance of `Ds\Map` and gets/sets on that instance...

#62 fixes the boolean cast issue but we still can't fetch into any of the structures.

Good catch! I'll fix this asap. I'm curious - why wrap around?

@ollieread we're going to rewrite parameter parsing for 2.0 that will fix this issue. I would recommend using `func_num_args` to determine whether to pass the callable, or perhaps splat `...$args`...