Rudi Theunissen

Results 191 comments of Rudi Theunissen

It can be any value. If you use a string as a key and an object that happens to hash into the same bucket, you must be able to do...

`equals` should never fail.

I think the best thing here would be to specify in the docs that object equality MUST be restricted to objects of the same class, or return false otherwise. The...

I'll update the docs 👍

> not sure about inheritance though. what if someone treats an object and an object of a child class as equal? They should then wrap them both in something that...

I think we should try to be as flexible as possible. 1. Do not enforce any types - the implementation has full control over the definition of equality. 2. Do...

Thanks for weighing in, I would like to come up with a solution for this. Going by your example, would `object instanceof this` not be more idiomatic? I know that...

Good call re: specific class. So if we were to typehint equals, and a mixed key comes long, we can't pass it to equals or the type check will fail....

2.0 won't support `allocate` so this is now a 1.* issue.

I think we should just remove explicit allocation entirely, in both 1.x and 2.0