Raj Tekal

Results 11 comments of Raj Tekal

>> (minor) You can create joins with the same table. We should probably filter itself out or throw an error on the BE when trying to create We did this...

@chriscollins3456 - Please review the PR and let us know. Thank you. These are all the cases we verified. ``` Join Tests JOIN_FEATURE_FLAG works when not present; the feature is...

@chriscollins3456 We can have a quick chat to review the current changes. I do not want this PR to become stale and get closed. Thank you.

@chriscollins3456, Few days ago we had a meeting in which, @shirshanka recommended us to use 'erModelRelation' (ER ModelRelation) in place of 'Join', so that it is more meaningful for the...

Sorry, corrected.... ER Model Relation

I thought I did all the replace, and while starting datahub I am seeing this error. I will continue to check and once tested will request a review. Thanks. Field...

I tested my changes after the change of name from 'Join' to 'ERModelRelation' Please review. Thanks.

Ensured again that there are no conflicts with master. Tested the functionality with and without the feature flag: ERMODELRELATION_FEATURE_ENABLED

Yep Chris. Took care of all your review comments. Please let me know. Thanks.