Romain Tavenard

Results 91 comments of Romain Tavenard

> Thanks for your responses. Amazing job with this package! > > @rtavenar - yes, I saw that metric argument, however, that would require me to recompute cdist_dtw(new_df) again, which...

Hi @NiuWenYu12138 In fact, if the length of the DTW path is smaller than the `max_length` you set, then LDTW and DTW will indeed return the same result. LDTW is...

Could you please provide an example of this behavior ?

Hum, I guess if we do it like that, there is a high chance that the package will not be installed on the target python. Shouldn't we rather state in...

Hi @tcoln Thanks for this feedback. I agree with @GillesVandewiele that hyper parameter setting is crucial, and that maybe with your code, we could give a hand. To the best...

Hi @felixdivo Shouldn't this be implemented in hdftools directly? Could you try to do it? Could we have an ugly fix like we append the type at the beginning /...

Something I dont get wrt this bug is that default value for probability is False so tests for this class should raise an error when accessing predict_proba Or maybe there...

@alevangel : could you post a code snippet that does that? This would be helpful: * for other users to see how to handle such errors * in the future...

I guess what we need is to merge `main`'s latest version on this branch and see if all tests pass, right?