tslearn icon indicating copy to clipboard operation
tslearn copied to clipboard

[WIP] Test against python 3.10

Open petoknm opened this issue 3 years ago • 10 comments

Fixes: #374 Now that we have tensorflow 2.8.0 with cp310 support, we can finally test against cp310.

petoknm avatar Feb 09 '22 13:02 petoknm

We might need #375 to be able to find a version of both numpy and sklearn that work in enough environments.

petoknm avatar Feb 11 '22 10:02 petoknm

We might need #375 to be able to find a version of both numpy and sklearn that work in enough environments.

Thank you so much once again for your contribution! There's a PR ready for that :) #379 , it still needs to get merged.

GillesVandewiele avatar Feb 11 '22 10:02 GillesVandewiele

@rtavenar can we re-run CI/CD and merge this PR if successful?

GillesVandewiele avatar Jun 09 '22 07:06 GillesVandewiele

I guess what we need is to merge main's latest version on this branch and see if all tests pass, right?

rtavenar avatar Jun 09 '22 07:06 rtavenar

Codecov Report

Merging #384 (be403c0) into main (ea1b19b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          59       59           
  Lines        4537     4537           
=======================================
  Hits         4290     4290           
  Misses        247      247           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea1b19b...be403c0. Read the comment docs.

codecov-commenter avatar Jun 09 '22 07:06 codecov-commenter

Hello, The tests failing are related to the "cesium" package which is not compatible with Python 3.10 yet. I have done a pull request (PR 305) on the cesium package to make it compatible with Python 3.10: https://github.com/cesium-ml/cesium/pull/305 This PR has been merged. Once the next version of the cesium package will be released, tslearn should also be compatible with Python 3.10. (I have asked to be informed when the next version of the cesium package will be released.)

YannCabanes avatar Jun 21 '22 18:06 YannCabanes

Once the next version of the cesium package will be released, tslearn should also be compatible with Python 3.10.

A new release of cesium is out.

stefanv avatar Jun 26 '22 05:06 stefanv

Hello @petoknm, Could you do an empty commit to re-run the continuous integration tests please?

YannCabanes avatar Jun 27 '22 15:06 YannCabanes

I have done a mistake, I just tried to do an empty commit on the main branch branch of petoknm, but it seems that I have done something different. I will try to correct it.

YannCabanes avatar Jun 29 '22 16:06 YannCabanes

I have reverted to the previous commit.

YannCabanes avatar Jun 29 '22 23:06 YannCabanes

The support for Python 3.10 has been added in PR #437 in which @petoknm has been added as a co-author. I now close the current PR #384.

YannCabanes avatar Jan 16 '23 19:01 YannCabanes