Rami Tabbara

Results 22 comments of Rami Tabbara

This has now been fixed in #1423

Hi @brabbitdousha , I'm going to close this as I think @merlinND has addressed your question. Please keep in mind that from Mitsuba 3.6.0 onwards, there are associated Dr.Jit changes...

Hi @denghilbert , this should now be fixed relative to the latest `master` but please reopen if you are still encountering issues.

Hi @nestor98, Apologies for the delay in getting back. This should now be resolved as of 944cb08 on `master`. I'll close this issue off but please reopen if you're still...

Added in Mitsuba 3.6.0 — see [ `mi.sggx_sample`](https://mitsuba.readthedocs.io/en/stable/src/api_reference.html#mitsuba.sggx_sample)

Also addresses Mitsuba issue [1280](https://github.com/mitsuba-renderer/mitsuba3/issues/1280)

@wjakob I've updated the PR so that instead the swizzle operation returns the original type if the swizzle size is compatible @Speierers I think I've fixed this now and added...

Hi @stymbhrdwj , Could you please provide a copy of the scene file/assets that you used so that we can attempt to reproduce the issue you're encountering?

Hi @stymbhrdwj, As you've discovered the issue was that the shading frame perturbations are computed internally within the normalmap BSDF itself and so you need some mechanism to fetch them...

Hi @stymbhrdwj, I had a look at this and the issue is in your implementation of the "default" vectorized function call `frame` in `bsdf.cpp` ``` MI_VARIANT Frame BSDF::frame( const SurfaceInteraction3f...