teb_local_planner icon indicating copy to clipboard operation
teb_local_planner copied to clipboard

Published 20 hours ago • verified publisher icon rst-tu-dortmund

Fix jazzy

Open Rayman opened this issue 10 months ago • 8 comments

This PR fixes the change in API for calculateMinAndMaxDistances due to the following PR: https://github.com/ros-planning/navigation2/pull/3875

This PR buils on top of the changes from: https://github.com/rst-tu-dortmund/teb_local_planner/pull/414

Rayman avatar Apr 02 '24 15:04 Rayman

Can somebody look at this PR?

Rayman avatar May 08 '24 14:05 Rayman

ping?

Timple avatar Sep 30 '24 05:09 Timple

pinging @corot as it seems you are the last one who merged something in this repository :slightly_smiling_face:

Timple avatar Oct 11 '24 06:10 Timple

pinging @corot as it seems you are the last one who merged something in this repository 🙂

I guess I'm the closest to a maintainer for this repo.... but I'm still stuck with ROS 1, so cannot test this. I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

corot avatar Oct 12 '24 15:10 corot

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create the following branches: humble-devel: contains the current ros2-master code iron-devel: contains this PR: https://github.com/rst-tu-dortmund/teb_local_planner/pull/414 ros2-master should contain https://github.com/rst-tu-dortmund/teb_local_planner/pull/414 + this PR

Rayman avatar Oct 14 '24 09:10 Rayman

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create the following branches: humble-devel: contains the current ros2-master code iron-devel: contains this PR: #414 ros2-master should contain #414 + this PR

I have created the humble branch and I will try the PR this week, and sync with @corot Thank you for the PR

renan028 avatar Oct 15 '24 01:10 renan028

I have created the humble branch and I will try the PR this week, and sync with @corot Thank you for the PR

thanks! what about the build farm to create the debians? I guess we need to change to use one branch or the other

also, I would not call it -devel... I expect pretty little additional development here

corot avatar Oct 18 '24 08:10 corot

@Rayman It looks like ros-jazzy-libg2o is not compatible with teb in this version. g2o::sign was removed (I have checked that it exists on latest release but not in g2o master branch) Did you manually change to use release to build it?

I have managed to build with this PR: https://github.com/rst-tu-dortmund/teb_local_planner/pull/425

@corot We will have to update the build farm. regarding the -devel, I have followed the repo convention.

renan028 avatar Oct 18 '24 11:10 renan028