rsocket-cpp

rsocket-cpp copied to clipboard

It is usually updated by the thread spawned inside RSocket. And the testing thread reads from it.

somasun

Current approach is awkward to cancel, would be cleaner to use AsyncTimeout. ``` timeout_ = folly::AsyncTimeout::schedule( std::chrono::milliseconds(heartbeatIntervalMs_), eventBase_, [this]() noexcept { heartbeat(); }); ... timeout_->scheduleTimeout(heartbeatIntervalMs_); ```

yschimke

Currently defaulting to latest (1.0), which should work with java. But the C++ tests should be run for all supported versions. https://github.com/rsocket/rsocket-cpp/blob/master/tck-test/client.cpp#L103

yschimke

StreamCompletionSignal options should match spec

2

Filing so I don't forget. We never use other values than `GRACEFUL` and `ERROR` from `StreamCompletionSignal`. There is an assert here that can never trigger because of this: https://github.com/ReactiveSocket/reactivesocket-cpp/blob/master/src/ConnectionAutomaton.cpp#L105 For...

lexs

FrameSerializer version code cleanup

4

https://github.com/ReactiveSocket/reactivesocket-cpp/blob/f1b862a23bc951bbe5869d03321eafa4f583a2a1/src/FrameSerializer.cpp - avoid flags in library code - handle versions greater than 9 - don't accept versions like ':.:' -> 10.10

yschimke

External components that want to use RSocketRequester and be unit tested need a way to mock this class. Gmock requires mocked classes to be virtual. Can we please split RSocketRequester...

fleupold

remove AllowanceSemaphore infinite

1

This isn't part of the spec anymore ``` bool isInfinite() const { return value_ == max(); } ```

yschimke

complete the story of reusing connection when resumability is not accepted by the server.

2

1. today the server doesn't communicate whether it will honor the resumability 2. on refused resume, the connection should be used to establish a new socket instance. We don't do...

lehecka

RSocket API TODOs

8

Ondrej and I capturing things we're finding to do - [x] requestResponse with Single type - [x] fireAndForget with Single type - [x] adopt yarpl::flowable::Subscriber/Subscription types in core code -...

benjchristensen

currently not supported and not exposed in ConnectionSetupPayload

yschimke