rsocket-cpp icon indicating copy to clipboard operation
rsocket-cpp copied to clipboard

FrameSerializer version code cleanup

Open yschimke opened this issue 7 years ago • 4 comments

https://github.com/ReactiveSocket/reactivesocket-cpp/blob/f1b862a23bc951bbe5869d03321eafa4f583a2a1/src/FrameSerializer.cpp

  • avoid flags in library code
  • handle versions greater than 9
  • don't accept versions like ':.:' -> 10.10

yschimke avatar Apr 21 '17 12:04 yschimke

This code also doesn't build on many Mac machines. I have to comment it out to compile.

//DEFINE_string(
//    rs_use_protocol_version,
//    "",
//    "override for the ReactiveSocket protocol version to be used"
//    " [MAJOR.MINOR].");

static std::string FLAGS_rs_use_protocol_version = "";

benjchristensen avatar Apr 28 '17 04:04 benjchristensen

@somasun any ideas on this?

benjchristensen avatar Apr 28 '17 04:04 benjchristensen

we should remove the GFLAG from the library and let the application code specify the version via SetupConnectionPayload.

lehecka avatar May 16 '17 13:05 lehecka

Is this still needing to be done after the recent refactoring?

benjchristensen avatar May 26 '17 19:05 benjchristensen