rsocket-cpp
rsocket-cpp copied to clipboard
FrameSerializer version code cleanup
https://github.com/ReactiveSocket/reactivesocket-cpp/blob/f1b862a23bc951bbe5869d03321eafa4f583a2a1/src/FrameSerializer.cpp
- avoid flags in library code
- handle versions greater than 9
- don't accept versions like ':.:' -> 10.10
This code also doesn't build on many Mac machines. I have to comment it out to compile.
//DEFINE_string(
// rs_use_protocol_version,
// "",
// "override for the ReactiveSocket protocol version to be used"
// " [MAJOR.MINOR].");
static std::string FLAGS_rs_use_protocol_version = "";
@somasun any ideas on this?
we should remove the GFLAG from the library and let the application code specify the version via SetupConnectionPayload.
Is this still needing to be done after the recent refactoring?