Robert Singer comments

Results 25 comments of


                                            Robert Singer

Callables for is_now?

That's interesting. I had not considered it. Is there a specific use case you're working on? Might be helpful for us to have something to work backward from.

Would you like to add github-actions to repository?

I think github actions are a good idea, would be nice to have everything integrated within GH. Do you want to do a proof of concept here? On Sun, Feb...

Support see changes for columns added during init

I'm not sure about this. If it's passed in __init__, then it's the initial value so it doesn't seem like it's really changed. There is no prior value. What about...

Expand not working as expected

As you're referencing the `BookSerializer` by string, try including the app name before it like this: ```python expandable_fields = { 'book': ('.BookSerializer', { 'source': 'book' }) } ```

Update access_view_set_mixin.py

It didn't occur to me that the mixin could call this automatically for the user. Thanks for the input. `scope_queryset` will always be defined because the version in the base...

Update access_view_set_mixin.py

yep, exactly :)

Update access_view_set_mixin.py

oh, good point about the breaking change. What do you think about introducing a new mixin called `StrictAccessViewSetMixin` that includes the change and leave the existing mixin as-is?

Add logging

thanks, I like this. Sorry, behind on this project. Will try to get to soon.

Support for expandable `SerializerMethodFields`

I like the idea of supporting DRF's `SerializerMethodField` as an expandable field. One thing, though, is that it doesn't take keyword arguments for `expand`, `omit`, `fields`. This would only matter...

Any ideas to enable a similar logic on frontend code

Thanks, I'm glad you like it :) I've thought about how this could be done a bit in the past, because I've had this use case as well. My idea...