Sercan Özdemir

Results 91 comments of Sercan Özdemir

> Thanks for getting started on this one. > > The database structure you're suggesting to implement is a bit unclear for me. Left some comments/questions. > > How are...

> One DEX buy order can be linked to multiple CEX orders, and vice-versa. > > For example, if there were many DEX orders fills with very small quantity. In...

oh I see @erkarl if that's okay by you guys, okay for me too ofc. @kilrau @erkarl

``` export interface Order { id: string; datetime: string; timestamp: number; lastTradeTimestamp: number; status: 'open' | 'closed' | 'canceled'; symbol: string; type: string; side: 'buy' | 'sell'; price: number; average?:...

As an outcome to our discussion, - I changed ArbyOrder name to `CexOrder` - Created two new db types `CexFee` & `CexTrade` - `CexFee` has one to one relation with...

So as per your comment @erkarl I suppose while saving fee into Order, I guess it's easier to do when we don't separate Fee as you said, I'm going to...

Hi @erkarl what I've added `saveOrder$` observable to executeOrder of Cex, could you please check? To be honest I couldn't test this %100 since it's not being used on test...

> > To be honest I couldn't test this %100 since it's not being used on test mode. > > You definitely should be able to test this manually. Uhm,...

Can you please check this once more @erkarl there was an issue because I was calling closeDB$ in cleanup but that's not right since DB close operation has to happen...

fyi. @erkarl I'll create a new branch over this one and will start HTTP implementation