Sercan Özdemir

Hello @raladev this was way more complicated than first I thought but eventually I guess I've done with the implementation, currently it only misses `nobalancecheck` flag. Could you please check...

@raladev I fixed logic of market orders for max, could you please recheck. For 100 sat error: That means I need to pull this logic from `orderbook.placeLimitOrder/placeMarketOrder` to Service. I'm...

I added exact same test case for BTC/USDT, it's getting calculated as 0.08276396689944529, can't get the conclusion you're at @raladev EDIT: 8276396.689944529 can this be in satoshis? Because it seems...

@raladev @kilrau could you please point out what to do for this PR then according to the @sangaman's review.

Changed flag to be only usable with limit orders, and throwing error in case of market orders, removed market tests. @raladev could you please check ? Regarding swap clients @raladev...

> > because connext currencies have different way for max amount calculation because of not-real max-buy bound - [#1922 (comment)](https://github.com/ExchangeUnion/xud/pull/1922#issuecomment-704409010) > > Gotcha. If we want to ignore the connext...

> * [x] remove max flag example for mkt order from the help > > ``` > xucli buy max BTC/USDT mkt place a market order to buy max BTC...

> > I couldn't get how creating `getMaximumInboundCapacity` would resolve it, since there's a calculation depending on this, and it would still require 4 if statements, if I'm not mistaken?...

I took a closer look at it, first of all keeping channels in the db requires a lot of effort to make it sync since opening and closing can happen...

> @rsercano thanks for doing the research on this one. > > One thing to consider is that remote peer's lnd pubkey could also change over time when running xud...