Robert Schulze

Throw out some `inline`s

5

As per #60469, CI was upgraded to Clang 18. Clang-tidy checks new in v18 were temporarily disabled. ~~This PR enables `readability-redundant-inline-specifier`.~~ Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/ Modify your CI run...

(wip) Integrate the query cache with Analyzer

1

(not ready for review) ### Changelog category (leave one): - Not for changelog (changelog entry is not required)

Query Cache: Consider identical queries against different databases as different

1

Fixes #64136 Consider: ```sql CREATE DATABASE db1; CREATE DATABASE db2; CREATE TABLE db1.tab(a UInt64, PRIMARY KEY a); CREATE TABLE db2.tab(a UInt64, PRIMARY KEY a); INSERT INTO db1.tab values(1); INSERT INTO...

Refactor statistics interface

2

As more statistics types are being added (looking at #65521), we should make the statistics interface more extensible. Review note: I described what changed and why in the individual commit...

Add missing include

2

`std::inserter` is defined in ``. libcxx 16 no longer includes this header transitively, therefore add it explicitly.

Fix libcxx build

4

Member variable `AvroRecord::m_values` is of type `std::vector` but `AvroDatum` is only forward-declared at that point. Newer libcxx versions reject such code. As a remedy, this PR moves class `AvroRecord` after...

Follow-up to #67294

2

Fixes some places in https://github.com/ClickHouse/ClickHouse/pull/67294 which I had to roll back due to failing tests (in this [commit](https://github.com/ClickHouse/ClickHouse/pull/67294/commits/f7c7d0b79bc4e24428264c33ed9074905ee684ea)). ### Changelog category (leave one): - Not for changelog (changelog entry is...

Remove obsolete `--multiquery` parameter from tests

1

This PR is follow-up to #63898, removing the obsolete `--multiquery` parameters from tests to avoid confusion why the parameter is still there and future cargo-cult copy-pasting of obsolete stuff into...

An issue about experimental join conditions (`allow_experimental_join_condition = 1`): This query does not work: ```sql SELECT foo.a FROM ( SELECT 1 AS a ) AS foo JOIN ( SELECT 2...

Less locking in `generateUUIDv7`

9

#63577 introduced function `generateSnowflakeId` which reserves a global increment per block instead of per row for better performance. Function `generateUUIDv7` (introduced by #62852) currently locks per row but it could...