Robert Schulze
Robert Schulze
@FrankChen021 I am reviewing right now ... sorry for the delay, I had to teach myself some OpenTelemetry first.
Thanks, this PR looks good overall (except the small-ish comment about "using namespace"). There have been some timeouts during test but that could also be caused by CI issues. Let's...
> do you confirm that if opentelemetry tracing is enabled for these tests? The CI first runs script "tests/config/install.sh" which creates a bunch of config files, including "opentelemetry.xml" where [opentelemetry_start_trace_probability](https://clickhouse.com/docs/en/operations/settings/settings/#opentelemetry-start-trace-probability)...
Thanks. In the tests which finished already, there is still a problem ``` 2022.09.01 02:09:39.402170 [ 9619 ] {} BaseDaemon: ######################################## 2022.09.01 02:09:39.402537 [ 9619 ] {} BaseDaemon: (version 22.9.1.1,...
To run one of the failing stateless test, 1. compile a debug build and 2. follow the steps described [here](https://clickhouse.com/docs/en/development/tests#functional-test-locally), e.g. `PATH=$PATH:build/programs/ tests/clickhouse-test 01428_hash_set_nan_key`
My pleasure 😉
The line numbers in the stack are a bit strange. @FrankChen021 Do you have an idea what could be the cause for the issues? (had a quick look but couldn't...
The PR is in good shape now and can be merged if the tests are green.
About Darwin: Please see my comment about changing "contrib-annoy" into an interface library. There is another failure in the [clang-tidy builds](https://s3.amazonaws.com/clickhouse-builds/37215/656ca5388c8d82c74af1c06966eaeb240885306f/binary_tidy/build_log.log) where a failure is reported for `annoylib.h` itself. ```...
> I can't make a PR from https://github.com/Vector-Similarity-Search-for-ClickHouse/annoy to https://github.com/ClickHouse/annoy because Clickhouse fork is not displayed. I've seen this situation before, when there was no access to repo (even for...