Robert Schulze

Results 90 comments of Robert Schulze

CLosed in favor of https://github.com/ClickHouse/ClickHouse/pull/66185 - thanks!

@cucumber95 I - expanded the tests to cover all edge cases - expanded the in-source docs - expanded the markdown docs - removed `Float*` and `Decimal*` as value argument types....

@cucumber95 Could you please sign the CLA? It somehow did not pick up your first commit which you made under the name "ubuntu". --> https://cla-assistant.io/ClickHouse/ClickHouse?pullRequest=63186

@cucumber95 This PR is good but without signed CLA we can unfortunately not continue. I'll close this PR for now. It would be great if you could pick it up...

Asked our legal team about this. @cucumber95 If you read this, kindly sign the CLA, thanks!

@kazalika I [reverted](https://github.com/ClickHouse/ClickHouse/pull/63577/commits/5d82a94615ef8a9fb7c39787d0e2b191641cbcb8) `generateSerialID` in reference to [my comment](https://github.com/ClickHouse/ClickHouse/pull/63577#discussion_r1606086659). Please create a new PR for `generateSerialID`, using a revert of the reverting commit as a starting point, thanks!

I polished the PR a bit, I think it is ready to go. Any objections? My Russian-speaking colleague was a bit confused what https://github.com/ClickHouse/ClickHouse/pull/63577#issuecomment-2127726041 means, is performance maybe too slow?

@kazalika You would also need to sign the CLA agreement, see https://cla-assistant.io/ClickHouse/ClickHouse?pullRequest=63577

@alexey-milovidov The original motivation for two functions was [generateUUIDv7](https://clickhouse.com/docs/en/sql-reference/functions/uuid-functions#generateUUIDv7) which comes in three forms (the "non-monotonic" variant does not make sense for snowflake ids so it was omitted). Anyways, thinking...