Robert Schulze

Results 90 comments of Robert Schulze

> This is strange as for 3rd-party libraries, compiler warnings (which are treated as error) should be generally muted. One way to achieve that is to mark included headers in...

@FArthur-cmd Sorry, I saw you pinged me earlier. If it is okay, I'd take a look tomorrow or on the weekend!

I got unfortunately side-tracked by other stuff but will check in one or two hours. Sorry for the delay.

I also had some recent troubles with memory sanitizer which failed with the same error as in some of the tests in this PR. The problem was that msan does...

@FArthur-cmd I am wondering if you could reproduce the issue locally in the meantime?

Just for reference: Adding the msan errors in the recent CI test runs: ``` #0 0x45da7bea in bool Annoy::AnnoyIndex::add_item_impl(unsigned long, float const* const&, char**) build_docker/../contrib/annoy/src/annoylib.h:920:22 #1 0x45da7bea in Annoy::AnnoyIndex::add_item(unsigned long,...

Ah, I have missed that the new memory is already 0-initialized. Thanks for pointing this out. @FArthur-cmd If you can't reproduce the issues, then it's best if we 1. merge...

Upon a brief look, it seems that at least the msan errors are fixed but there are many errors remaining. I'll try to reproduce locally.

I ran `PATH=$PATH:build/programs/ tests/clickhouse-test 02354_annoy` on a local debug build. This test aborts in [CI with the new `bad_alloc` exception thrown even without sanitizers](https://s3.amazonaws.com/clickhouse-test-reports/37215/1d048432a1691ba8332b99b6b8a549270f2de229/stateless_tests__debug__[3/3].html). In file "annoylib.h", ``` _nodes =...

Thanks. The last error in in the ASTFuzzer: ``` ("../contrib/annoy/src/annoylib.h:918:8: runtime error: member access within misaligned address 0x7f4ab075724c for type 'Annoy::AnnoyIndex::Node' (aka 'Node'), which requires 8 byte alignment Received signal...