Ryan Christian

Results 344 comments of Ryan Christian

> This works great during the runtime, but fails during the SSR build. Whoops. Sorry about that. Should've added a `&& !env.isServer` to that conditional. > did some digging but...

This should fix your issues: ```bash $ npm i critters-webpack-plugin ``` ```js // preact.config.js import Critters from 'critters-webpack-plugin'; export default (config, env, helpers) => { if (env.isProd && !env.isServer) {...

Let me know if you're still having issues and I can reopen.

> Using webpack for the pre-rendering is REALLY slowing preact down. I really doubt this is the case, and your benchmarks certainly haven't shown it. Your script is faster because...

> It is the out of the box comparison time, which is always the first benchmark for users of a framework, e.g. me. That's a bit of a horrifying thing...

> Then --prerender is buggy, because the output of my fast build is the same as the default output. There is no route specific output Apologies, apparently our preload is...

I meant to reply to your original comment re:WMR, but forgot to apparently. > I know that all this would apply more to WMR by now, but the documentation is...

> you had previously reccomended to look into wmr https://github.com/preactjs/preact-cli/pull/1501#issuecomment-862763299 but you you mentioned above it has not been maintained. Yes, as in June, WMR was seeing a lot more...

Looking over issues again for v4 and I'll try to make some movement for our prerendering. If anyone has large repos to share I'd love to take a look for...

Really the only rules are `src/assets` -> `build/assets`, `src/static` -> `build/`, `src/manifest` -> `build/manifest`. The `template.html` -> `index.html` (or as many routes as you prerender) exists to emphasize that this...