Rebecca Schlussel
Rebecca Schlussel
Thanks for the detailed design! This looks like a great optimization. Some details to think about for the implementation and a question: 1. names of feature flags should be easy...
Merged. Thanks @feilong-liu! In the future, also be sure to add a release note in the PR description as per the template (Added one already here)
Other than still needing automated tests for this feature, I don't have additional concerns.
Another thing that should be cleaned up for constraint optimization is to make all the property fields immutable, and instead create them in their final state. There isn’t really a...
For Presto, NaNs should be treated the same. We haven't decided on +/-0. Having them be treated as different is easiest from a code perspective because it aligns with built...
normalizing seems tricky (would need to normalize after every operation on a double), but we can do a custom comparator.
> If it is a useful/functional piece we should keep it. Who knows maybe we will find use for it! The problem is that it's buggy and it's not clear...
> Is squash and merge enabled on the repo? squash and merge is not enabled on this repo. We require rebase and merge.
I'm still updating the tests. Don't review yet
this is ready for review (failing tests are flaky/unrelated)