Rolf Schäuble

Results 10 comments of Rolf Schäuble

@AYapejian: would a pull request that adds an "output initial state" flag to those nodes be welcome? If yes, then I'll try adding it.

I'm not sure how I should self-review a documentation change. @KevinOConnor: could you have a quick look, as we were having the discussion about these event handlers in another PR...

This actually happened to me with moonraker-timelapse, whose Moonraker plugin executes GCode once Klippy is ready.

@flowerysong: you are right; making the whole branch conditional is better. I've changed the code accordingly.

Alright, so here's a self-review based on the steps from https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review: 1. I have tested the change on my printer; it works as expected and solves the problem. Tests run...

@KevinOConnor: I had this problem when using moonraker-timelapse. It's [Moonraker plugin](https://github.com/mainsail-crew/moonraker-timelapse/blob/main/component/timelapse.py) executes GCode once Klippy is ready. The executed [GCode](https://github.com/mainsail-crew/moonraker-timelapse/blob/main/klipper_macro/timelapse.cfg) uses `UPDATED_DELAYED_GCODE`. When that happens before delayed_gcode has fully initialized,...

@KevinOConnor: your comments and questions made me look deeper into how Moonraker and Klipper interact. klippy.py contains the following code: ```python self._set_state(message_ready) for cb in self.event_handlers.get("klippy:ready", []): if self.state_message is...

I have to admit that I don't really understand how Klipper's reactor works, and what causes a "yield' and what doesn't. However, I have a suspicion: I'm using the [klipper_tmc_autotune](https://github.com/andrewmcgr/klipper_tmc_autotune/tree/main)...

I’ll try sending a PR to autotune_tmc that fixes this. It’s a nasty issue, quite hard to diagnose, and could trigger all kinds of issues in the future. Please allow...

Thank you for the answers, Kevin. Here's the PR for the documentation: https://github.com/Klipper3d/klipper/pull/6702 And here's the PR for autotune_tmc, for those interested in that: https://github.com/andrewmcgr/klipper_tmc_autotune/pull/203.