Russ Cox

Results 790 comments of Russ Cox

I need to reread all this and think more carefully about it. It's clear there's a can of worms we should try to avoid opening.

> `ServeFSFile` confuses the `http` package's interactions with files and filesystems even more. > > Right now, we have `http.FileSystem`, `http.Dir`, and `http.File` types, `http.FileServer` and `http.NewFileTransport` functions which operate...

Then the new API is: ``` package http func ServeFileFS(w ResponseWriter, r *Request, fsys fs.FS, name string) func FileServerFS(root fs.FS) Handler func NewFileTransportFS(fsys fs.FS) RoundTripper ``` Retitled. Does anyone object...

We're not going to move just these three into a separate package. http.FS is already in net/http.

Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. — rsc for the proposal review group

We haven't gotten this out of incoming yet, sorry. It won't be for Go 1.18.

This proposal has been added to the [active column](https://golang.org/s/proposal-status#active) of the proposals project and will now be reviewed at the weekly proposal review meetings. — rsc for the proposal review...

I'm confused about ``` func (something) HandleXML(r xml.TokenReader, start *xml.StartElement) error { d := xml.NewTokenDecoderElement(r, start) var foo someType d.DecodeElement(&foo, start) ``` Why does start appear twice? What is wrong...

Instead of xml.NewTokenDecoderElement, what about adding a Push method to Decoder, like: ``` package xml // Push pushes the token onto the input stack, so that the next call to...