Richard R

Results 32 comments of Richard R

Although it's good to think about secondary properties and plan ahead, I think we should prioritise getting a simple pipeline working for v0.2

Discussing with @aamara we should use halotools where possible as this is a requirement for astropy affiliation. It has [`HodModelFactory`](https://halotools.readthedocs.io/en/latest/api/halotools.empirical_models.HodModelFactory.html#) and [`SubhaloModelFactory`](https://halotools.readthedocs.io/en/latest/api/halotools.empirical_models.SubhaloModelFactory.html#) base classes that we can use to build...

The Vale+Ostriker halo-galaxy matching algorithm is already implemented #70 we just need to write a model to generate the subhalo population #148. That code can also match on circular velocities...

I am much less familiar with HOD, if it's an alternative to SHAM we should choose one to start with and get a simple pipeline working for v0.2. Probably SHAM...

@bnord I'm not sure if you are referring to something simple here such as associating discrete galaxies with halos i.e. SHAM or something more complex such as how halo properties...

With respect to Vale+Ostriker SHAM we have already implemented the halo-galaxy matching routine #70 but still need to work on generating (sub)halo populations by mass #13 #148

Great first draft @itrharrison I like the format and lots of nice ideas for content! I'll keep an updated list of my own comments here as I think of them:...

@katie-davidson I cannot reproduce the error you are seeing without a minimum working example; please provide a simple config file or python script. However, I note that as currently implemented...

TLDR: replace the relevant lines in your config with: ``` m_min: 1.e+9 m_max: 1.e+12 ``` In YAML 1.1 `1e+9` and `1e+12` are not valid scientific notation so these entries in...

> @rrjbca to play the audio files, I'll use this `import IPython IPython.display.Audio("skypy_active.wav")` > > Does that mean we need to make IPython a dependency in SkyPy only to run...