rr-bw

Results 21 comments of rr-bw

@alec-livefront I'm still reviewing this, but for now I did notice that clicking "Login with master password" on Web does not automatically navigate to the vault. https://github.com/user-attachments/assets/d3287938-eb68-44b4-8bde-aa64419278fa

@jlf0dev looks like some tests are failing

> Storybook does not reflect the change, I'm guessing that may be because the Theme service is not available in Storybook. @rr-bw can you confirm this is expected? Yes, that's...

@danielleflinn Ok, I hardcoded the marketing brand colors, using #FFF on dark theme and #175DDC on light theme.

After a conversation with @danielleflinn, I also added a brief note in the [Storybook Docs](https://62a88a6de5b807fa98886113-umqnraivfn.chromatic.com/?path=/docs/auth-anon-layout--docs) about AnonLayout usage. The note clarifies that while AnonLayout is primarily used for unauthenticated pages,...

> I also just noticed that the success toasts weren't showing in the videos, are those from the previous iteration of this PR? @jlf0dev Yes, those were previous videos. Here's...

> I do agree that both the browser and desktop MP policy callouts look a bit off though. Is there a way we can fix the spacing between the leftmost...

@jlf0dev I addressed the recent feedback and also updated the PR description with a new screencast for each client. I am having one issue with Browser. As you can see...

> I am having one issue with Browser. As you can see in the video, setting the password works fine, but I cannot get the account to sync with the...

> Are we able to make the title of this page "Join organization" (once we can support[ dynamic text](https://bitwarden.atlassian.net/browse/PM-9603) in the Anon layout title we can update this to "Join...