clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-1779] switch to broadcast channel for sso connector

Open jlf0dev opened this issue 8 months ago â€ĸ 3 comments

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-1779

📔 Objective

Removes the use of window.postMessage from the sso connector

Autofill changes

I've added broadcast channel message handling to the content script message handler since I'd like for Auth to utilize same-origin messaging apis (like broadcast channel) where we can. Let me know if you disagree with this, thanks!

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jlf0dev avatar Jun 19 '24 18:06 jlf0dev