clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-1779] switch to broadcast channel for sso connector

Open jlf0dev opened this issue 1 year ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-1779

📔 Objective

Removes the use of window.postMessage from the sso connector

Autofill changes

I've added broadcast channel message handling to the content script message handler since I'd like for Auth to utilize same-origin messaging apis (like broadcast channel) where we can. Let me know if you disagree with this, thanks!

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jlf0dev avatar Jun 19 '24 18:06 jlf0dev

Logo Checkmarx One – Scan Summary & Details – bb7dda54-146f-4d17-9dea-eb1aec217128

No New Or Fixed Issues Found

github-actions[bot] avatar Jun 19 '24 18:06 github-actions[bot]

@jlf0dev looks like some tests are failing

rr-bw avatar Jun 26 '24 17:06 rr-bw

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.52%. Comparing base (c01f6be) to head (afcb185). Report is 2 commits behind head on main.

Files Patch % Lines
apps/web/src/connectors/sso.ts 0.00% 3 Missing :warning:
...er/src/autofill/content/content-message-handler.ts 77.77% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9733      +/-   ##
==========================================
+ Coverage   29.46%   29.52%   +0.06%     
==========================================
  Files        2537     2538       +1     
  Lines       74045    74148     +103     
  Branches    13827    13852      +25     
==========================================
+ Hits        21814    21893      +79     
- Misses      50579    50594      +15     
- Partials     1652     1661       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 21:06 codecov[bot]