Romain Quinio

Results 48 comments of Romain Quinio

I had the same need ^^ I'm calling compile goal during generate-resources phase, and then altering the html files in process-resources phase, via ant: ``` Replacing .less imports by .css...

I faced similar issue. It seems less.js does not handle relative paths the same way in browser mode and outside... cf. https://github.com/cloudhead/less.js/pull/331 So had to keep all less files in...

Not sure it's possible to avoid a `quarkus.openshift.route.tls` (and `quarkus.kubernetes.ingress.tls`) build time config to enable TLS & termination, because quarkus.http.ssl.certificate.* can change at runtime, so values are not known when...

This can leverage the work done for #2749 Impacted class should be https://github.com/GoogleContainerTools/jib/blob/master/jib-core/src/main/java/com/google/cloud/tools/jib/image/json/ManifestListGenerator.java#L47-L49 I guess the choice between V22ManifestListTemplate or OciIndexTemplate should be driven by the already existing configuration container...

No worries. Hopefully I've fixed the formatting issue.

Done ! I also took the opportunity to fix missing coverage in PullBaseImageStep for manifest lists pulling and case where the target architecture is not in the list.

Should be fixed, testCall_allMirrorsFail was wrongly using the client factory with new V22ManifestList mocks, instead of the old V22ManifestTeplate mock.

@elefeint I've added a test for POJO -> JSON serialization. I had a look at the code duplication, but I wouldn't risk factorizing the JSON objects between docker and OCI...

In the case of https://github.com/quarkusio/quarkus/issues/11903 I think the issue is that each sub-module execution of quarkus:build happens with a different classloder for class LockFile. The multi-threading lock relies on a...

The stacktrace is a bit clearer with jib-core 0.21.0: Stacktrace ``` [error]: Build step io.quarkus.container.image.jib.deployment.JibProcessor#buildFromJar threw an exception: java.lang.RuntimeException: Unable to create container image at io.quarkus.container.image.jib.deployment.JibProcessor.containerize(JibProcessor.java:256) at io.quarkus.container.image.jib.deployment.JibProcessor.buildFromJar(JibProcessor.java:182) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native...