Radek Poleski
Radek Poleski
Currently coverage is 72% and we should work on increasing it. - [ ] `caustics.py` `critical_curve()` - [x] `event.py` `__init__()` with fix_source_flux_ratio commit https://github.com/rpoleski/MulensModel/commit/562bc2a0c49bc21f52017640e5abc995fb17edbb - [ ] `event.py` `calculate_chi2_gradient()` with...
In `event.py` we're calling: `MulensData._plot_datapoints()` `MulensData._set_plot_properties()` which should not be done. Maybe there are other similar cases to correct.
The test `test_get_d_u_d_params()` in `test_FitData.py` has to be corrected: 1. It uses private function (`_get_d_u_d_params()`) which should not happen. 2. It only tests if answer is different than for calculation...
In 2021, I was asked by Geoff if MM has built-in capability to calculate and plot magnification maps. The answer was: "not yet." We should change that.
The function `_get_ylim_for_best_model_plot()` has a condition `y_err < 0.`, but `y_err` there is scaled flux uncertainty. I think it can be negative only if either `data_source_flux` or `source_flux` in `FitData.scale_fluxes()`...
Can someone help me with increasing coverage of code by tests? As an example in `model.py` we have a function: ```python def update_caustics(self, epoch=None): if self.n_lenses == 1: self._update_caustics_single_lens() elif...
`ModelParamets._count_sources()` doesn't have `t_eff_1` or `t_eff_2`. Should be trivial to add it.