Radek Poleski
Radek Poleski
In #121 @kingwithqueen suggested to add `examples/` and subdirectories to the PiP installation, so that they can be easily run after the code is installed. I'm not sure what's done...
In SciPy v1.10 (repeased Jan 3, 2023) `interp2d()` (used only in pointlens.py) is deprecated and will be removed in v1.12 (probably Jan 2024). We have to replace it with [`LinearNDInterpolator`](https://docs.scipy.org/doc/scipy/reference/generated/scipy.interpolate.LinearNDInterpolator.html)...
- [ ] Delta `t_0` is not saved anywhere Things that are borderline between bug and missing enhancement: - [ ] print script version - [ ] save fixed parameters...
Some useful changes to be done after xal branch is merged: - [x] Example 16 - add xallarap parameters to `_set_default_parameters()` and `_check_fixed_parameters()` - [x] change `ModelParameters._check_valid_combination_1_source_standard()` so that it...
It's a bad practice to do "import *" in python. It can be replaced using specific imports or using `__all__` in imported files. We should remove "import *" from `__init__.py`...
@wyrzykow asked for barycentric parallax parametrization. I think I know how to get it, but have not yet tested. Can someone provide values from independent code for tests?
There is an aspect of binary source models that seems a bit strange for me know, but I see that it could be "it's user's reponsibility" approach. The issue is...
Task to be done to have a model with binary source and their full orbital motion ([BSPL\_xallarap branch](https://github.com/rpoleski/MulensModel/tree/BSPL_xallarap)): - [x] make sure `.n_sources` for xallarap models depends on whether `q_source`...
@przemekmroz informed me that he found bug in parallax calculation for model with `t_E` calculated from `t_eff` and `u_0` for negative `u_0`. `Trajectory` calls `ModelParameters.t_E` for tau calculation. For this...
`Model.get_trajectory()` returns a single instance of a Trajectory, even if the model is a binary source one. ALSO: check all other calls to `Trajectory()` and think how they work for...