Parth Raiyani

Results 26 comments of Parth Raiyani

On the similar line, Should we also remove all uno command elements instead of disabling them in Read Only mode? cc: @eszkadev @Darshan-upadhyay1110

> hiding not disabling patch - is fine removing serveraudit in readonly - I think it could be useful for admin tom check also RO case @eszkadev Thank you for...

> we need to solve merge conflict, @rparth07 are you still working on it? :) Thank you for the update. I’ll take care of resolving the merge conflicts.

I resolved the merge conflicts and enabled serveraudit option for admin. Can you please review @eszkadev @Darshan-upadhyay1110 Thanks :)

> To check those locally and see what it happens and where it fails you ca run the following in the save Collabora Online directory that you normally do `make...

Additionally, although it's a minor change, I noticed that in the previous version, all color values were in uppercase. To maintain consistency, I updated them accordingly in the current version.

> Hello @rparth07 what is the status here is it done? or you have more changes to be in ? @Darshan-upadhyay1110 Changes are done. Review is pending :)

### Doubts: - **Approach:** Is the use of the `disableSpellCheckIfReadOnly` method appropriate for managing the `spellOnline` property based on `isReadOnly`? Are there any concerns with this approach? - **Constructor Call:**...

I'm not sure, do we need LOKit patch to enable commands status? cc: @pedropintosilva @Darshan-upadhyay1110

> > I'm not sure, do we need LOKit patch to enable commands status? cc: @pedropintosilva @Darshan-upadhyay1110 > > Hii @rparth07 thanks for the PR. > > - Have you...