Results 195 comments of Rob Parrett

> Does `tileset_with_spacing.png` appear correct in Bevy ? It should, yes. You would need to set the `offset` correctly in [`from_grid`](https://docs.rs/bevy/latest/bevy/sprite/struct.TextureAtlas.html#method.from_grid) > I see in the .wgsl that spacing considerations...

Correctly as in zero / not the same as `padding`.

Here's a branch that adds a Tiled map with two tilesets: - One with 1px spacing and 1px margin (first set of tiles displayed) - One with 1px spacing and...

> If I'm understanding correctly, you're just confirming that results are incorrect for 1px Spacing, 0px Margin ? Yeah. In other words, I am not seeing an issue beyond #353....

Thanks for the report. Glad that workaround worked for you. > So presumably removing AnimatedTile just needs to trigger changed state? If you can point me in the right direction,...

@andriyDev is it possible to use https://docs.rs/bevy/latest/bevy/render/render_asset/struct.ExtractedAssets.html instead of doing the manual collecting/extraction?

It seems like the answer to the above is probably no. Sorry, but I don't think I can provide a meaningful review. I don't think I'll be able to get...

Looks like CI is just failing due to new `let-else` formatting in rust 1.72 in an unrelated file.

> They both look roughly the same to me. I agree. Seems fine as-is IMO.

Hey @andriyDev, could I bug you to update the branch again? It looks like a relatively straightforward rebase. We should be in a better position to try to get this...