Rob Parolin comments

Results 28 comments of


                                            Rob Parolin

wrong types used in fixedpoint-header

Good catch! Did you want to submit a PR?

EASTL throwing std::exceptions

We use the exceptions code path internally but its definitely not used as widely. This is an excellent observation that we should look at resolving because its currently not implemented...

hetergenenous key lookup - std::map::find template method

This is how EASTL achieved heterogeneous key lookup before the standard adopted the change. ie. using a 'const char*' to find a key of type 'eastl::string'. https://abseil.io/tips/144 I haven't done...

Various numeric_limits functions are not constexpr on MSVC

For sure we can update the existing path to make it constexpr. Feel free to submit a PR. Thanks for checking.

eastl::list::splice using copy operator when it shouldn't

``` template inline void list::splice(const_iterator position, list& x, const_iterator i) { if(mAllocator == x.mAllocator) { iterator i2(i.mpNode); ++i2; if((position != i) && (position != i2)) { ((ListNodeBase*)position.mpNode)->splice((ListNodeBase*)i.mpNode, (ListNodeBase*)i2.mpNode); #if EASTL_LIST_SIZE_CACHE...

eastl::fixed_vector<.., .., false> problem when using modern GCC

Yeah, this is a legitimate issue as the exhausted fixed_allocator can't allocate an overflow so it has to return nullptr. Are you planning on contributing a PR to fix this?

Properly define in CMakeList EASTL_DLL and EAST_API if shared

We already define EASTL_API in the config.h header. EA_DLL should be defined by the build system. ```#if defined(EA_DLL) && !defined(EASTL_DLL) #define EASTL_DLL 1 #endif #ifndef EASTL_API // If the build...

Properly define in CMakeList EASTL_DLL and EAST_API if shared

Sorry, my bad I thought we defined both in the header. I'll accept the PR if you submit it. Thanks!

[Feature Request] In VScode, it's not possible to "jump-to-definition" if the definition is in a .mojopkg

Thanks for flagging. Someone on the Tooling team will take a look shortly.

[BUG] Return values are correct, but REPL reports incorrect

You should see a fix for this in the next nightly.