roystgnr

Results 312 comments of roystgnr

Queso doesn't use cmake; it uses autotools. https://github.com/libqueso/queso/#installation

Is there a Makefile.export.Epetra installed? You might need a Trilinos configuration option to enable export Makefiles ... assuming Trilinos still has such an option? I don't think Queso has been...

`RELEASE_NOTES` on the latest Trilinos git head still mentions "the Makefile.export.* system", so it's at least still an option. If you want to rewrite trilinos.m4 here to make it more...

Yeah, I bet it was annoyances like this that led me to just not care about us doing things like specializing `std::hash`. If your language can't figure out that `pair`...

There's definitely a lot of short vector use in `GenericProjector` that I'd *think* could get a lot faster from a Small-Size Optimization pass ... but IIRC when we tried that...

Score! Those Distributed mesh sweep issues look unrelated too ... though I'm a bit concerned about what might have caused them to regress. I'll start going through the code tomorrow.

Forbidding the transfer for (very) small meshes might be reasonable. Forcing an error for near-0 insertions, not so reasonable; it's too easy to do some mesh manipulation that you expect...

>now if you built your mesh at 1e-13 because your mesher output 1e-13 instead of 0 for the first point, then we're out of luck. This literally is one use...

Yeah, that's an approval. I think we're good to merge once whatever's going on with Griffin gets sorted.

> I made the decision to prioritize readability here My biggest vague misgiving with this area of code is that it feels like the Doxygen (in the existing pre-PR code)...