moose
moose copied to clipboard
Add stationary ray output
Closes #26604
Job Documentation on 48f4a85 wanted to post the following:
View the site here
This comment will be updated on new commits.
Requires https://github.com/libMesh/libmesh/pull/3770
@roystgnr if you wouldn't mind taking a look at this. You're probably the best candidate for a review
Job Coverage on 48f4a85 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Ray tracing
c531dc | #26606 48f4a8 | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 95.32% | 95.33% | +0.01% | 100.00% | |
Hits | 4356 | 4364 | +8 | 74 | |
Misses | 214 | 214 | - | 0 |
Full coverage reports
Reports
-
framework
-
chemical_reactions
-
combined
-
contact
-
electromagnetics
-
external_petsc_solver
-
fluid_properties
-
fsi
-
functional_expansion_tools
-
geochemistry
-
heat_transfer
-
level_set
-
misc
-
navier_stokes
-
optimization
-
peridynamics
-
phase_field
-
porous_flow
-
ray_tracing
-
rdg
-
reactor
-
richards
-
scalar_transport
-
solid_mechanics
-
solid_properties
-
stochastic_tools
-
thermal_hydraulics
-
xfem
This comment will be updated on new commits.
Using the vectorized NumericVector::insert() might be faster than the repeated set() calls, but I doubt it's a hotspot so I wouldn't bother.
Yeah, there's a lot in here that's not particularly optimized but I made the decision to prioritize readability here because it's already pretty complex as is figuring out all of the numbering 😬
I made the decision to prioritize readability here
My biggest vague misgiving with this area of code is that it feels like the Doxygen (in the existing pre-PR code) and the comments would benefit from being elaborated on, to about twice their current verbosity ... but I couldn't really find any specific bits to complain about, so I didn't bother; it's impossible to productively criticize a "vibe".
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
Don't close. @gsgall still needs and can pester me about it