moose icon indicating copy to clipboard operation
moose copied to clipboard

Add stationary ray output

Open loganharbour opened this issue 1 year ago • 7 comments

Closes #26604

loganharbour avatar Jan 22 '24 22:01 loganharbour

Job Documentation on 48f4a85 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Jan 23 '24 00:01 moosebuild

Requires https://github.com/libMesh/libmesh/pull/3770

loganharbour avatar Jan 23 '24 04:01 loganharbour

@roystgnr if you wouldn't mind taking a look at this. You're probably the best candidate for a review

loganharbour avatar Jan 23 '24 04:01 loganharbour

Job Coverage on 48f4a85 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Ray tracing

c531dc #26606 48f4a8
Total Total +/- New
Rate 95.32% 95.33% +0.01% 100.00%
Hits 4356 4364 +8 74
Misses 214 214 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Jan 23 '24 14:01 moosebuild

Using the vectorized NumericVector::insert() might be faster than the repeated set() calls, but I doubt it's a hotspot so I wouldn't bother.

Yeah, there's a lot in here that's not particularly optimized but I made the decision to prioritize readability here because it's already pretty complex as is figuring out all of the numbering 😬

loganharbour avatar Jan 24 '24 15:01 loganharbour

I made the decision to prioritize readability here

My biggest vague misgiving with this area of code is that it feels like the Doxygen (in the existing pre-PR code) and the comments would benefit from being elaborated on, to about twice their current verbosity ... but I couldn't really find any specific bits to complain about, so I didn't bother; it's impossible to productively criticize a "vibe".

roystgnr avatar Jan 24 '24 15:01 roystgnr

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 04 '24 05:05 github-actions[bot]

Don't close. @gsgall still needs and can pester me about it

loganharbour avatar May 15 '24 04:05 loganharbour