Rowen Willabus
Rowen Willabus
While working on https://github.com/rubyforgood/human-essentials/pull/3998 I noticed that inactive items are being reactivated upon editing distribution. I found that to be odd and may need some help understanding that.
@dorner The gotcha regarding the edit was mentioned by @cielf: https://github.com/rubyforgood/human-essentials/issues/3988#issuecomment-1869000531 Initially, I shared the same train of thought (editing a distribution, to add a new item, shouldn't allow an...
@cielf @dorner The issue stated "inactive" with an explanation on how to make an item inactive. Should we expand that to omit inactive (by status change) **AND** items with no...
They wouldn't see that. They would only see items that can be added to the distribution. If they pick an item without any inventory and attempt to move forward, the...
> What would the effect of that be on a case where we are creating a distribution from a request that has an item that has 0 in inventory? Will...
@dorner Thanks for mentioning that as I went down a rabbit hole and found some ways in which we can improve the process. E.g a request may have multiple distributions...
Right. What I'm working on affects only the `new` method. I'll wrap this up within a few minutes.