Andrew Rove (Rover)

Generic Job definition moved to this follow up PR https://github.com/endless-sky/endless-sky/pull/7762

Changing to the following on suggestions from @quyykk ``` cargo outfit ... ``` ``` cargo outfitter ... ```

@quyykk I think that should do it. Let me know what you think about the refactor.

@quyykk Updated with master and ready for review again

I am willing to come back and rework this but no one seemed interested in coming back to review it.

Have stuff this week with my child’s birthday party. Going to take a swing at this next week.

As a follow up to this should all defense installations are working now require outfit space and/or energy to balance things out? Otherwise people can just stack put defense stations...

When we turned on caching the first issue we ran into was that it was thinking the array of cache keys was one giant cache key. Thus the splat operator....

Still results in an array of escaped JSON strings. https://github.com/rails/rails/blob/08754f12e65a9ec79633a605e986d0f1ffa4b251/activesupport/lib/active_support/json/encoding.rb#L79 Rails wraps all strings it turns into JSON in 'EscapedString's. This removes the to_json method on JSONString. If we make...

@beauby I think the issue is we are using rails 4